pulsar icon indicating copy to clipboard operation
pulsar copied to clipboard

[fix][broker] avoid offload system topic

Open mattisonchao opened this issue 1 year ago • 2 comments

Motivation

Avoid setting broker internal system topics using off-loader because some of them are the preconditions of other topics. The slow replying log speed will cause a delay in all the topic loading.(timeout)

Modifications

  • Add a condition check for offload policies.

Verifying this change

  • [x] Make sure that the change passes the CI checks.

Documentation

  • [ ] doc
  • [ ] doc-required
  • [x] doc-not-needed
  • [ ] doc-complete

mattisonchao avatar Apr 13 '24 04:04 mattisonchao

@mattisonchao Why do we closed this PR?

dao-jun avatar Apr 29 '24 02:04 dao-jun

discussed with @mattisonchao , reopen the PR

dao-jun avatar Apr 29 '24 04:04 dao-jun

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 41.94%. Comparing base (bbc6224) to head (5ca0963). Report is 236 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #22497       +/-   ##
=============================================
- Coverage     73.57%   41.94%   -31.63%     
+ Complexity    32624    15011    -17613     
=============================================
  Files          1877     1749      -128     
  Lines        139502   139850      +348     
  Branches      15299    16220      +921     
=============================================
- Hits         102638    58660    -43978     
- Misses        28908    73885    +44977     
+ Partials       7956     7305      -651     
Flag Coverage Δ
inttests 28.65% <100.00%> (+4.07%) :arrow_up:
systests 25.80% <100.00%> (+1.48%) :arrow_up:
unittests 37.66% <100.00%> (-35.19%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...rg/apache/pulsar/broker/service/BrokerService.java 62.21% <100.00%> (-18.57%) :arrow_down:

... and 1437 files with indirect coverage changes

codecov-commenter avatar May 08 '24 02:05 codecov-commenter