pulsar icon indicating copy to clipboard operation
pulsar copied to clipboard

[fix][fn] Unwrap type from CompletableFuture when getting function's type args

Open jiangpengcheng opened this issue 1 year ago • 1 comments

Fixes #22067

Main Issue: #xyz

PIP: #xyz

Motivation

When inferring function type args, it doesn't unwrap the CompletableFuture type

Modifications

unwrap the CompletableFuture type for the output

Verifying this change

  • [x] Make sure that the change passes the CI checks.

  • [x] This change added tests and can be verified as follows:

(example:)

  • *Added unittests in org.apache.pulsar.functions.utils.FunctionCommonTest#testGetFunctionTypes

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • [ ] Dependencies (add or upgrade a dependency)
  • [ ] The public API
  • [ ] The schema
  • [ ] The default values of configurations
  • [ ] The threading model
  • [ ] The binary protocol
  • [ ] The REST endpoints
  • [ ] The admin CLI options
  • [ ] The metrics
  • [ ] Anything that affects deployment

Documentation

  • [ ] doc
  • [ ] doc-required
  • [x] doc-not-needed
  • [ ] doc-complete

Matching PR in forked repository

PR in forked repository: https://github.com/jiangpengcheng/pulsar/pull/26

jiangpengcheng avatar Feb 18 '24 09:02 jiangpengcheng

@jiangpengcheng Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

github-actions[bot] avatar Feb 18 '24 09:02 github-actions[bot]