pulsar icon indicating copy to clipboard operation
pulsar copied to clipboard

[improve] [broker] Enable AppendBrokerTimestampMetadataInterceptor by default

Open 315157973 opened this issue 1 year ago • 1 comments

Main Issue: #21347

Motivation

When the client machine's clock is incorrect (eg: set to 1 year later) and the Broker does not set the AppendBrokerTimestampMetadataInterceptor, the Ledger will not be cleaned up. Because if the Broker's timestamp is not set, the expiration check will be based on the client's publish time.

As we discuss in https://lists.apache.org/thread/0vtjt436xvlg0fr4ogchkjdvjcp56mvz

Modifications

Enable AppendBrokerTimestampMetadataInterceptor by default

Verifying this change

  • [x] Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:

  • [x] The default values of configurations

  • [x] doc-not-needed

Matching PR in forked repository

PR in forked repository: https://github.com/315157973/pulsar/pull/13

315157973 avatar Jan 22 '24 06:01 315157973

@315157973 Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

github-actions[bot] avatar Jan 22 '24 06:01 github-actions[bot]