pulsar icon indicating copy to clipboard operation
pulsar copied to clipboard

[improve][functions] EFFECTIVELY_ONCE mode support input topic batching

Open graysonzeng opened this issue 2 years ago • 1 comments

Fixes #17061

Main Issue: #17061

Motivation

The batch message will generate the same sequence ID in the function, which will cause a large amount of data in the batch message to be mistakenly deduplicated when EFFECTIVELY_ONCE mode and enable message deduplication.

Modifications

Use Interceptor with org.apache.pulsar.common.intercept.AppendIndexMetadataInterceptor and enable exusingBrokerEntryMetadataToClientEnabled on the broker。In the batch message we can generate the sequenceId of the sequence and get it using record.getSequenceId()

Verifying this change

  • [x] Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • [ ] Dependencies (add or upgrade a dependency)
  • [ ] The public API
  • [ ] The schema
  • [ ] The default values of configurations
  • [ ] The threading model
  • [ ] The binary protocol
  • [ ] The REST endpoints
  • [ ] The admin CLI options
  • [ ] The metrics
  • [ ] Anything that affects deployment

Documentation

  • [ ] doc
  • [ ] doc-required
  • [x] doc-not-needed
  • [ ] doc-complete

Matching PR in forked repository

PR in forked repository:

graysonzeng avatar Dec 28 '23 03:12 graysonzeng

@jiangpengcheng @freeznet PTAL

graysonzeng avatar Jan 18 '24 03:01 graysonzeng