pulsar icon indicating copy to clipboard operation
pulsar copied to clipboard

[fix] Error in obtaining network card related information under linux or mac os

Open XuQianJin-Stars opened this issue 2 years ago • 3 comments

Fix error in obtaining network card related information under linux or mac os

Motivation

企业微信截图_45b27c2b-b570-4951-8333-dbc628abeb01

Modifications

Verifying this change

  • [ ] Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • [ ] Dependencies (add or upgrade a dependency)
  • [ ] The public API
  • [ ] The schema
  • [ ] The default values of configurations
  • [ ] The threading model
  • [ ] The binary protocol
  • [ ] The REST endpoints
  • [ ] The admin CLI options
  • [ ] The metrics
  • [ ] Anything that affects deployment

Documentation

  • [ ] doc
  • [ ] doc-required
  • [x] doc-not-needed
  • [ ] doc-complete

Matching PR in forked repository

PR in forked repository:

XuQianJin-Stars avatar Dec 21 '23 03:12 XuQianJin-Stars

@XuQianJin-Stars Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

github-actions[bot] avatar Dec 21 '23 03:12 github-actions[bot]

Why involves hutool?

Well, I'll add a class to remove this dependency.

XuQianJin-Stars avatar Dec 22 '23 01:12 XuQianJin-Stars

Codecov Report

Attention: Patch coverage is 59.52381% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 74.04%. Comparing base (bbc6224) to head (1d6c3fa). Report is 205 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #21773      +/-   ##
============================================
+ Coverage     73.57%   74.04%   +0.47%     
- Complexity    32624    33191     +567     
============================================
  Files          1877     1887      +10     
  Lines        139502   140648    +1146     
  Branches      15299    15464     +165     
============================================
+ Hits         102638   104143    +1505     
+ Misses        28908    28451     -457     
- Partials       7956     8054      +98     
Flag Coverage Δ
inttests 27.19% <47.61%> (+2.61%) :arrow_up:
systests 24.47% <47.61%> (+0.15%) :arrow_up:
unittests 73.34% <59.52%> (+0.50%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...org/apache/pulsar/broker/loadbalance/OshiUtil.java 38.46% <38.46%> (ø)
...ache/pulsar/broker/loadbalance/LinuxInfoUtils.java 57.52% <68.96%> (+1.17%) :arrow_up:

... and 276 files with indirect coverage changes

codecov-commenter avatar Dec 27 '23 04:12 codecov-commenter