pulsar icon indicating copy to clipboard operation
pulsar copied to clipboard

[improve][doc] Add language support flag for --cleanup-subscription

Open jiangpengcheng opened this issue 1 year ago • 6 comments

Fixes #xyz

Main Issue: #xyz

PIP: #xyz

Motivation

Modifications

Verifying this change

  • [x] Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • [ ] Dependencies (add or upgrade a dependency)
  • [ ] The public API
  • [ ] The schema
  • [ ] The default values of configurations
  • [ ] The threading model
  • [ ] The binary protocol
  • [ ] The REST endpoints
  • [ ] The admin CLI options
  • [ ] The metrics
  • [ ] Anything that affects deployment

Documentation

  • [x] doc
  • [ ] doc-required
  • [ ] doc-not-needed
  • [ ] doc-complete

Matching PR in forked repository

PR in forked repository:

jiangpengcheng avatar Jul 19 '23 03:07 jiangpengcheng

This PR adds docs for https://github.com/apache/pulsar/pull/20028

Anonymitaet avatar Jul 19 '23 06:07 Anonymitaet

@jiangpengcheng I've re-run the failed tests many times but still failed, can you ptal? (you can try git merge origin/master and then re-run tests)

Anonymitaet avatar Aug 07 '23 03:08 Anonymitaet

/pulsarbot rerun-failure-checks

jiangpengcheng avatar Aug 08 '23 08:08 jiangpengcheng

Codecov Report

Merging #20836 (aa03b7c) into master (2ab184e) will decrease coverage by 0.42%. Report is 16 commits behind head on master. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #20836      +/-   ##
============================================
- Coverage     37.11%   36.69%   -0.42%     
- Complexity    12250    12478     +228     
============================================
  Files          1698     1698              
  Lines        129813   133553    +3740     
  Branches      14156    14653     +497     
============================================
+ Hits          48179    49008     +829     
- Misses        75318    78137    +2819     
- Partials       6316     6408      +92     
Flag Coverage Δ
inttests 24.16% <ø> (-0.23%) :arrow_down:
systests 25.10% <ø> (-0.30%) :arrow_down:
unittests 32.28% <ø> (+0.06%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...java/org/apache/pulsar/admin/cli/CmdFunctions.java 0.00% <ø> (ø)

... and 88 files with indirect coverage changes

codecov-commenter avatar Aug 18 '23 08:08 codecov-commenter

The pr had no activity for 30 days, mark with Stale label.

github-actions[bot] avatar Sep 18 '23 01:09 github-actions[bot]

/pulsarbot rerun-failure-checks

jiangpengcheng avatar Jan 30 '24 07:01 jiangpengcheng