pulsar icon indicating copy to clipboard operation
pulsar copied to clipboard

[improve][broker] Add bookkeeperDeleted in topic internal stats.

Open dragonls opened this issue 2 years ago • 2 comments

Motivation

Shows the offload detail of the ledgers whether it is deleted in bookkeeper.

The ./bin/pulsar-admin topics stats-internal command now shows the ledger info of specific topic. If we are using offloader, we can know the offloaded of the ledger but not be able to know whether it is deleted in bookkeeper.

image

Modifications

Add bookkeeperDeleted field in org.apache.pulsar.common.policies.data.ManagedLedgerInternalStats.LedgerInfo.

Fill the bookkeeperDeleted in all places where offloaded be filled.

Verifying this change

  • [ ] Make sure that the change passes the CI checks.

This change added tests and can be verified as follows:

  • org.apache.pulsar.tests.integration.offload.TestBaseOffload#testPublishOffloadAndConsumeDeletionLag

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • [ ] Dependencies (add or upgrade a dependency)
  • [ ] The public API
  • [ ] The schema
  • [ ] The default values of configurations
  • [ ] The threading model
  • [ ] The binary protocol
  • [ ] The REST endpoints
  • [ ] The admin CLI options
  • [ ] The metrics
  • [ ] Anything that affects deployment

Documentation

  • [ ] doc
  • [x] doc-required
  • [ ] doc-not-needed
  • [ ] doc-complete

Matching PR in forked repository

PR in forked repository: https://github.com/dragonls/pulsar/pull/11

dragonls avatar Jul 18 '23 11:07 dragonls

The pr had no activity for 30 days, mark with Stale label.

github-actions[bot] avatar Sep 07 '23 01:09 github-actions[bot]

very good for me

liudezhi2098 avatar Oct 25 '23 06:10 liudezhi2098