pulsar icon indicating copy to clipboard operation
pulsar copied to clipboard

[pip][design] PIP-269. Add an epoch of cursor to discard outdated reading

Open poorbarcode opened this issue 1 year ago • 10 comments

Motivation & Modifications

Start a PIP: Add an epoch of cursor to discard outdated reading

Documentation

  • [ ] doc
  • [x] doc-required
  • [ ] doc-not-needed
  • [ ] doc-complete

Matching PR in forked repository

PR in forked repository: x

poorbarcode avatar Jun 02 '23 01:06 poorbarcode

@tisonkun

Thanks for update the title of this PR

poorbarcode avatar Jun 02 '23 02:06 poorbarcode

@jiazhai Please note - due to new PIP process, PMC members can only approve a PIP (which is a PR) once voted in mailing list. Can you undo please?

asafm avatar Jun 04 '23 19:06 asafm

Per the PIP process (new) as you see here title should start with [pip][design] PIP- - this is that we can have search that only shows PIPs.

asafm avatar Jun 04 '23 19:06 asafm

@poorbarcode Please see my comment from before:

Per the PIP process (new) as you see here title should start with [pip][design] PIP- - this is that we can have search that only shows PIPs.

asafm avatar Jun 11 '23 14:06 asafm

This may mean number is wrong

asafm avatar Jun 11 '23 14:06 asafm

Ping me when all comments have been reviewed

asafm avatar Jun 11 '23 14:06 asafm

This may mean number is wrong

Do you mean the number of PIP? It is correct.

Per the PIP process (new) as you see here title should start with [pip][design] PIP- - this is that we can have search that only shows PIPs.

The current title check does not seem to support design. I submitted a PR to improve it.

Ping me when all comments have been reviewed

Done. Please take a look. I've changed a lot, but the main design hasn't changed.

poorbarcode avatar Jun 12 '23 05:06 poorbarcode

Confirmed w/ @codelipenghui, for 3.1, the code will be frozen next week, and this PR will not be merged into 3.1.

Anonymitaet avatar Jul 21 '23 04:07 Anonymitaet

The pr had no activity for 30 days, mark with Stale label.

github-actions[bot] avatar Sep 04 '23 01:09 github-actions[bot]

What is the current progress of this pip? @poorbarcode

zhanghaou avatar Jan 29 '24 06:01 zhanghaou