pulsar
pulsar copied to clipboard
[fix][ml]fix wrong cursor state if repeat do close
Motivation
Do curosr.close twice.
expect cursor state: Closed
actual cursor state: Closing
Modifications
Fixed the state change logic
Documentation
- [ ]
doc - [ ]
doc-required - [x]
doc-not-needed - [ ]
doc-complete
Matching PR in forked repository
PR in forked repository:
- https://github.com/poorbarcode/pulsar/pull/37
this PR should merge into these branches:
- 2.9
- 2.10
- 2.11
- master
Codecov Report
Merging #18340 (bbceaa3) into master (a2c1534) will decrease coverage by
4.46%. The diff coverage is63.63%.
@@ Coverage Diff @@
## master #18340 +/- ##
============================================
- Coverage 51.47% 47.00% -4.47%
- Complexity 7410 10360 +2950
============================================
Files 405 692 +287
Lines 44012 67775 +23763
Branches 4517 7263 +2746
============================================
+ Hits 22656 31860 +9204
- Misses 18935 32325 +13390
- Partials 2421 3590 +1169
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 47.00% <63.63%> (-4.47%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| ...che/bookkeeper/mledger/impl/ManagedCursorImpl.java | 36.97% <63.63%> (ø) |
|
| ...rvice/schema/KeyValueSchemaCompatibilityCheck.java | 21.62% <0.00%> (-45.95%) |
:arrow_down: |
| .../apache/pulsar/broker/admin/impl/PackagesBase.java | 54.12% <0.00%> (-13.77%) |
:arrow_down: |
| ...oker/service/schema/SchemaRegistryServiceImpl.java | 57.35% <0.00%> (-6.31%) |
:arrow_down: |
| ...pulsar/broker/service/PulsarCommandSenderImpl.java | 67.53% <0.00%> (-5.76%) |
:arrow_down: |
| ...ava/org/apache/pulsar/broker/service/Consumer.java | 69.50% <0.00%> (-2.31%) |
:arrow_down: |
| ...pache/pulsar/broker/admin/v2/PersistentTopics.java | 71.68% <0.00%> (-2.29%) |
:arrow_down: |
| .../org/apache/pulsar/broker/admin/v2/Namespaces.java | 57.36% <0.00%> (-2.14%) |
:arrow_down: |
| ...ervice/AbstractDispatcherSingleActiveConsumer.java | 69.15% <0.00%> (-1.87%) |
:arrow_down: |
| ...rg/apache/pulsar/broker/web/PulsarWebResource.java | 56.43% <0.00%> (-1.87%) |
:arrow_down: |
| ... and 315 more |
@Technoboy-
It's better to compare all the state.
already fixed. Thanks
/pulsarbot rerun-failure-checks
Can this PR merge? (^_^)