pulsar icon indicating copy to clipboard operation
pulsar copied to clipboard

[cleanup][broker]remove legacy code

Open aloyszhang opened this issue 2 years ago • 1 comments

Motivation

remove legacy code

Modifications

remove legacy code

Verifying this change

  • [ ] Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

Documentation

  • [x] doc-not-needed

aloyszhang avatar Nov 04 '22 02:11 aloyszhang

@aloyszhang Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

github-actions[bot] avatar Nov 04 '22 02:11 github-actions[bot]

/pulsarbot run-failure-checks

codelipenghui avatar Nov 10 '22 04:11 codelipenghui

Codecov Report

Merging #18330 (62f4a6a) into master (8b404d4) will decrease coverage by 2.01%. The diff coverage is 6.12%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #18330      +/-   ##
============================================
- Coverage     47.15%   45.13%   -2.02%     
- Complexity    10432    10630     +198     
============================================
  Files           697      758      +61     
  Lines         68023    72738    +4715     
  Branches       7284     7804     +520     
============================================
+ Hits          32074    32831     +757     
- Misses        32367    36213    +3846     
- Partials       3582     3694     +112     
Flag Coverage Δ
unittests 45.13% <6.12%> (-2.02%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rg/apache/pulsar/broker/service/AbstractTopic.java 65.45% <ø> (+0.58%) :arrow_up:
...he/pulsar/client/impl/MultiTopicsConsumerImpl.java 22.98% <0.00%> (+0.71%) :arrow_up:
...n/java/org/apache/pulsar/client/util/NoOpLock.java 0.00% <0.00%> (ø)
...va/org/apache/pulsar/client/impl/ConsumerImpl.java 15.12% <7.69%> (+0.28%) :arrow_up:
...va/org/apache/pulsar/client/impl/ConsumerBase.java 21.93% <16.66%> (-0.02%) :arrow_down:
.../transaction/buffer/metadata/AbortTxnMetadata.java 28.57% <0.00%> (-57.15%) :arrow_down:
...ion/buffer/metadata/TransactionBufferSnapshot.java 42.85% <0.00%> (-42.86%) :arrow_down:
...saction/timeout/TransactionTimeoutTrackerImpl.java 50.87% <0.00%> (-36.85%) :arrow_down:
...oker/loadbalance/LoadResourceQuotaUpdaterTask.java 44.44% <0.00%> (-33.34%) :arrow_down:
...er/impl/SingleSnapshotAbortedTxnProcessorImpl.java 51.19% <0.00%> (-29.77%) :arrow_down:
... and 117 more

codecov-commenter avatar Nov 10 '22 04:11 codecov-commenter