pulsar
pulsar copied to clipboard
[improve][broker] Code simplify in `AbstractBaseDispatcher` in filterEntriesForConsumer loop
Fixes #18328
Modifications
-
batch
subscription.acknowledgeMesagein filterEntriesForConsumer loop -
remove unnecessary Optional package parameter for
filterEntriesForConsumermetadataArray -
avoid call O(consumer) times of
topic.getMigratedClusterUrlincheckAndApplyReachedEndOfTopicOrTopicMigration
Verifying this change
- [ ] Make sure that the change passes the CI checks.
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
- [ ] Dependencies (add or upgrade a dependency)
- [ ] The public API
- [ ] The schema
- [ ] The default values of configurations
- [ ] The threading model
- [ ] The binary protocol
- [ ] The REST endpoints
- [ ] The admin CLI options
- [ ] Anything that affects deployment
Documentation
- [ ]
doc - [ ]
doc-required - [x]
doc-not-needed - [ ]
doc-complete
@codelipenghui @eolivelli @rdhabalia sorry for all the change in commit, can you guys take a look?