pulsar icon indicating copy to clipboard operation
pulsar copied to clipboard

[fix][test] fix testEndTxnWhenCommittingOrAborting flaky test

Open congbobo184 opened this issue 3 years ago • 1 comments

issue: https://github.com/apache/pulsar/actions/runs/3383985489/jobs/5620564078

Motivation

Transaction op count update after the write response, so we need to wait for the change to succeed https://github.com/congbobo184/pulsar/blob/2b441bd2ab4b71d5bc182f85c62fbea633c4ce4b/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/PulsarCommandSenderImpl.java#L314-L317

https://github.com/congbobo184/pulsar/blob/2b441bd2ab4b71d5bc182f85c62fbea633c4ce4b/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/PulsarCommandSenderImpl.java#L334-L337

Modifications

wait count changed

Verifying this change

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • [ ] Dependencies (add or upgrade a dependency)
  • [ ] The public API
  • [ ] The schema
  • [ ] The default values of configurations
  • [ ] The threading model
  • [ ] The binary protocol
  • [ ] The REST endpoints
  • [ ] The admin CLI options
  • [ ] Anything that affects deployment

Documentation

  • [ ] doc
  • [ ] doc-required
  • [x] doc-not-needed
  • [ ] doc-complete

Matching PR in forked repository

PR in forked repository: https://github.com/congbobo184/pulsar/pull/7

congbobo184 avatar Nov 03 '22 09:11 congbobo184

@poorbarcode mainly to fix the flaky test, this is just to remove the wrong logic

congbobo184 avatar Nov 04 '22 08:11 congbobo184

The pr had no activity for 30 days, mark with Stale label.

github-actions[bot] avatar Dec 05 '22 02:12 github-actions[bot]

new flaky-test case:

  • https://github.com/apache/pulsar/actions/runs/3935861095/jobs/6732032238

poorbarcode avatar Jan 17 '23 06:01 poorbarcode

@lhotari could you review this PR? link issue: https://github.com/apache/pulsar/issues/18605

poorbarcode avatar Jan 17 '23 06:01 poorbarcode