pulsar icon indicating copy to clipboard operation
pulsar copied to clipboard

[improve][client] PIP-218: Consumer batchReceive() single partition every receive

Open congbobo184 opened this issue 3 years ago • 1 comments

Motivation

https://github.com/apache/pulsar/issues/18182

Modifications

Verifying this change

add test for batchReceive single topic messages add test for batchReceive multi-topic messages

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • [ ] Dependencies (add or upgrade a dependency)
  • [x] The public API
  • [ ] The schema
  • [ ] The default values of configurations
  • [ ] The threading model
  • [ ] The binary protocol
  • [ ] The REST endpoints
  • [ ] The admin CLI options
  • [ ] Anything that affects deployment

Documentation

  • [ ] doc
  • [x] doc-required
  • [ ] doc-not-needed
  • [ ] doc-complete

Matching PR in forked repository

PR in forked repository:

  • https://github.com/congbobo184/pulsar/pull/5

congbobo184 avatar Nov 03 '22 08:11 congbobo184

Codecov Report

Merging #18316 (4726fc6) into master (41edd2e) will decrease coverage by 0.16%. The diff coverage is 58.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #18316      +/-   ##
============================================
- Coverage     47.06%   46.90%   -0.17%     
+ Complexity    10620    10586      -34     
============================================
  Files           709      709              
  Lines         69423    69428       +5     
  Branches       7448     7452       +4     
============================================
- Hits          32677    32562     -115     
- Misses        33102    33223     +121     
+ Partials       3644     3643       -1     
Flag Coverage Δ
unittests 46.90% <58.33%> (-0.17%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...va/org/apache/pulsar/client/impl/ConsumerBase.java 21.39% <12.50%> (-0.13%) :arrow_down:
...pulsar/broker/admin/impl/PersistentTopicsBase.java 59.52% <81.25%> (+0.08%) :arrow_up:
...rvice/schema/KeyValueSchemaCompatibilityCheck.java 21.62% <0.00%> (-45.95%) :arrow_down:
...java/org/apache/pulsar/proxy/stats/TopicStats.java 58.82% <0.00%> (-41.18%) :arrow_down:
...lsar/broker/loadbalance/impl/ThresholdShedder.java 3.27% <0.00%> (-27.05%) :arrow_down:
...e/pulsar/broker/service/EntryBatchIndexesAcks.java 82.14% <0.00%> (-10.72%) :arrow_down:
...org/apache/pulsar/broker/loadbalance/LoadData.java 58.33% <0.00%> (-8.34%) :arrow_down:
...pulsar/broker/service/PulsarCommandSenderImpl.java 60.20% <0.00%> (-5.62%) :arrow_down:
...roker/loadbalance/impl/ModularLoadManagerImpl.java 64.59% <0.00%> (-4.54%) :arrow_down:
...sar/broker/service/schema/SchemaRegistryStats.java 71.25% <0.00%> (-3.75%) :arrow_down:
... and 30 more

codecov-commenter avatar Nov 03 '22 08:11 codecov-commenter

The pr had no activity for 30 days, mark with Stale label.

github-actions[bot] avatar Dec 11 '22 02:12 github-actions[bot]

The pr had no activity for 30 days, mark with Stale label.

github-actions[bot] avatar Jan 23 '23 02:01 github-actions[bot]

Hi @congbobo184, Did you have any plans for updating the docs?

momo-jun avatar Feb 13 '23 09:02 momo-jun