pulsar icon indicating copy to clipboard operation
pulsar copied to clipboard

[improve][broker]Create missed subscriptions for createMissedPartitions

Open Pomelongan opened this issue 3 years ago • 2 comments

Motivation

org.apache.pulsar.broker.admin.impl.PersistentTopicsBase#internalCreateMissedPartitions lacks the logic to create subscriptions.

Modifications

  • add org.apache.pulsar.broker.admin.impl.PersistentTopicsBase#createMissedSubscriptionsAsync
  • add the logic for creating missed subscriptions for org.apache.pulsar.broker.admin.impl.PersistentTopicsBase#internalCreateMissedPartitions

Verifying this change

  • [x] Make sure that the change passes the CI checks.

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • [ ] Dependencies (add or upgrade a dependency)
  • [ ] The public API
  • [ ] The schema
  • [ ] The default values of configurations
  • [ ] The binary protocol
  • [ ] The REST endpoints
  • [ ] The admin CLI options
  • [ ] Anything that affects deployment

Documentation

  • [ ] doc
  • [ ] doc-required
  • [ ] doc-not-needed
  • [x] doc-complete

Matching PR in forked repository

PR in forked repository: https://github.com/Pomelongan/pulsar/pull/9

Pomelongan avatar Oct 05 '22 15:10 Pomelongan

LGTM, Can we add a unit test to verify this?

OK, have update UT, PTAL @Jason918

Pomelongan avatar Oct 08 '22 09:10 Pomelongan

I have updated based on comments.PTAL @AnonHxy

Pomelongan avatar Oct 19 '22 06:10 Pomelongan

The pr had no activity for 30 days, mark with Stale label.

github-actions[bot] avatar Dec 13 '22 02:12 github-actions[bot]