pulsar icon indicating copy to clipboard operation
pulsar copied to clipboard

[improve][cli] Add proxyServiceUrl / proxyProtocol parsing from conf file to pulsar-client CLI

Open lhotari opened this issue 3 years ago • 1 comments

Motivation

#17862 added support for pulsar-perf CLI tools (with #17930 to fix some gaps). It would be consistent to add support for specifying proxyServiceUrl & proxyProtocol in the configuration file also for pulsar-client CLI tool.

Modifications

Add proxyServiceUrl / proxyProtocol parsing from conf file to pulsar-client CLI.

Documentation

  • [ ] doc
  • [ ] doc-required
  • [x] doc-not-needed
  • [ ] doc-complete

Matching PR in forked repository

PR in forked repository: https://github.com/lhotari/pulsar/pull/95

lhotari avatar Oct 04 '22 16:10 lhotari

The pr had no activity for 30 days, mark with Stale label.

github-actions[bot] avatar Nov 04 '22 02:11 github-actions[bot]

/pulsarbot rerun-failure-checks

lhotari avatar Nov 04 '22 21:11 lhotari

Codecov Report

Merging #17932 (d9885c2) into master (67d9d63) will increase coverage by 6.81%. The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #17932      +/-   ##
============================================
+ Coverage     40.29%   47.10%   +6.81%     
- Complexity     8685    10331    +1646     
============================================
  Files           687      687              
  Lines         67441    67437       -4     
  Branches       7225     7226       +1     
============================================
+ Hits          27175    31768    +4593     
+ Misses        37257    32090    -5167     
- Partials       3009     3579     +570     
Flag Coverage Δ
unittests 47.10% <0.00%> (+6.81%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...che/bookkeeper/mledger/impl/ManagedCursorImpl.java 36.87% <0.00%> (-0.03%) :arrow_down:
...rg/apache/bookkeeper/mledger/impl/OpReadEntry.java 65.55% <ø> (+0.72%) :arrow_up:
.../transaction/TransactionCoordinatorClientImpl.java 0.00% <0.00%> (ø)
...rvice/schema/KeyValueSchemaCompatibilityCheck.java 21.62% <0.00%> (-45.95%) :arrow_down:
.../apache/pulsar/broker/loadbalance/LoadManager.java 61.11% <0.00%> (-16.67%) :arrow_down:
.../apache/pulsar/broker/admin/impl/PackagesBase.java 54.12% <0.00%> (-13.77%) :arrow_down:
...pulsar/broker/service/PulsarCommandSenderImpl.java 67.53% <0.00%> (-10.48%) :arrow_down:
...oker/service/schema/SchemaRegistryServiceImpl.java 56.75% <0.00%> (-8.11%) :arrow_down:
...tent/PersistentDispatcherSingleActiveConsumer.java 55.79% <0.00%> (-3.45%) :arrow_down:
...ookkeeper/mledger/impl/ManagedCursorContainer.java 76.03% <0.00%> (-3.31%) :arrow_down:
... and 196 more

codecov-commenter avatar Nov 04 '22 21:11 codecov-commenter