apache
[fix][broker] ClassCastException when specify flow_or_qps_equally_div…
splitAlgorithm is alreay specified by user or default before input to this method. It will initial wrong option type and throw ClassCastException when user specified FlowOrQpsEquallyDivideBundleSplitAlgorithm and default is not.
@zhangqian321 Please add the following content to your PR description and select a checkbox:
- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Codecov Report
:exclamation: No coverage uploaded for pull request base (
master@0678b82). Click here to learn what that means. The diff coverage isn/a.
@@ Coverage Diff @@
## master #17872 +/- ##
=========================================
Coverage ? 45.70%
Complexity ? 17526
=========================================
Files ? 1573
Lines ? 128208
Branches ? 14097
=========================================
Hits ? 58597
Misses ? 63557
Partials ? 6054
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 45.70% <0.00%> (?) |
Flags with carried forward coverage won't be shown. Click here to find out more.
how can we miss such ClassCastException in the Pulsar code? didn't we add any unit-test case for the PR which caused this failure? certainly, not good practice in code have such RuntImeException. I am seeing a lot of such instances lately in Pulsar which should be avoided. Because of such practice, it takes a lot of minor releases to have a stable release. I am seeing a lot of necessary PRs without reviews and merging such PRs which keeps creating instability in code.
