pulsar icon indicating copy to clipboard operation
pulsar copied to clipboard

[improve][misc] Add IssueNavigationLink for IDEA git log

Open alpreu opened this issue 3 years ago • 2 comments

Motivation

This enables GitHub hyperlinks in IDEA for commits containing PR information. Clicking on the link will directly open the corresponding GitHub PR. See screenshots below: NOW Screenshot 2022-09-21 at 13 38 54 BEFORE Screenshot 2022-09-21 at 13 42 06

Modifications

  • changed .gitignore
  • added vcs.xml IDEA file

Verifying this change

  • [ ] Make sure that the change passes the CI checks.

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • [ ] Dependencies (add or upgrade a dependency)
  • [ ] The public API
  • [ ] The schema
  • [ ] The default values of configurations
  • [ ] The binary protocol
  • [ ] The REST endpoints
  • [ ] The admin CLI options
  • [ ] Anything that affects deployment

Documentation

  • [ ] doc-required (Your PR needs to update docs and you will update later)

  • [x] doc-not-needed (Please explain why)

  • [ ] doc (Your PR contains doc changes)

  • [ ] doc-complete (Docs have been already added)

Matching PR in forked repository

PR in forked repository: https://github.com/alpreu/pulsar/pull/1

alpreu avatar Sep 21 '22 11:09 alpreu

As a follow-up, we could improve this even further by also linking to the corresponding WIKI page for PIPs.

This would require a change to future PIP URLs in the wiki. Right now they are either a Github Issue URL or in the form of https://github.com/apache/pulsar/wiki/PIP-198:-Standardize-PR-Naming-Convention-using-GitHub-Actions To have a deterministic link all future PIPs would need to be created in the wiki and the URL would need to look like https://github.com/apache/pulsar/wiki/PIP-198 This is an entirely different discussion though.

alpreu avatar Sep 21 '22 11:09 alpreu

Nice improvement!

lhotari avatar Sep 21 '22 11:09 lhotari

thank you for this update.

heesung-sohn avatar Sep 21 '22 20:09 heesung-sohn

/pulsarbot run-failure-checks

alpreu avatar Sep 23 '22 08:09 alpreu