pulsar
pulsar copied to clipboard
[fix][txn] Fix TransactionTest failure due to clean up after class
Motivation
Fix testGetTxnID, testSubscriptionRecreateTopic and testPendingAckMarkDeletePosition can not pass since the broker is not cleaned up.
Modification
fix the testGetTxnID, and move the testSubscriptionRecreateTopic and testPendingAckMarkDeletePosition to adapt AfterClass in TransactionTest.
Verifying this change
- [ ] Make sure that the change passes the CI checks.
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
- Added integration tests for end-to-end deployment with large payloads (10MB)
- Extended integration test for recovery after broker failure
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
- [ ] Dependencies (add or upgrade a dependency)
- [ ] The public API
- [ ] The schema
- [ ] The default values of configurations
- [ ] The binary protocol
- [ ] The REST endpoints
- [ ] The admin CLI options
- [ ] Anything that affects deployment
Documentation
-
[ ]
doc-required
(Your PR needs to update docs and you will update later) -
[x]
doc-not-needed
(Please explain why) -
[ ]
doc
(Your PR contains doc changes) -
[ ]
doc-complete
(Docs have been already added)
Matching PR in forked repository
PR in forked repository: https://github.com/liangyepianzhou/pulsar/pull/3
After opening this PR, the build in apache/pulsar will fail and instructions will be provided for opening a PR in the PR author's forked repository.
apache/pulsar pull requests should be first tested in your own fork since the apache/pulsar CI based on GitHub Actions has constrained resources and quota. GitHub Actions provides separate quota for pull requests that are executed in a forked repository.
The tests will be run in the forked repository until all PR review comments have been handled, the tests pass and the PR is approved by a reviewer.
-->