pulsar icon indicating copy to clipboard operation
pulsar copied to clipboard

[fix][metrics]wrong metrics text generated when label_cluster specified

Open poorbarcode opened this issue 3 years ago • 3 comments

Motivation

If label_cluster specified cluster_123, the expected metrics text is:

metrics_xxx_total{cluster="cluster_123"} 1.0

but the exactly metrics text is :

metrics_xxx_totalcluster="cluster_123"} 1.0

High light: lost a char {

Modifications

Make metrics text generate correct

Documentation

  • [ ] doc-required

  • [x] doc-not-needed

  • [ ] doc

  • [ ] doc-complete

Matching PR in forked repository

PR in forked repository:

  • https://github.com/poorbarcode/pulsar/pull/5

poorbarcode avatar Sep 17 '22 08:09 poorbarcode

@poorbarcode Please provide a correct documentation label for your PR. Instructions see Pulsar Documentation Label Guide.

github-actions[bot] avatar Sep 17 '22 08:09 github-actions[bot]

This PR should merge into the following branches:

  • master
  • branch-2.11
  • branch-2.10

poorbarcode avatar Sep 17 '22 08:09 poorbarcode

/pulsarbot rerun-failure-checks

poorbarcode avatar Sep 19 '22 15:09 poorbarcode

/pulsarbot rerun-failure-checks

poorbarcode avatar Sep 22 '22 13:09 poorbarcode

Hi @Technoboy-

Can this PR merge? (^_^)

poorbarcode avatar Sep 27 '22 01:09 poorbarcode