pulsar icon indicating copy to clipboard operation
pulsar copied to clipboard

[improve][txn]PIP-160 make txn components supports buffered writer metrics

Open poorbarcode opened this issue 3 years ago • 2 comments

Master Issue: #15370

Modifications

  • Make transaction MLTransactionMetadataStoreProvider & MLPendingAckStoreProvider support buffered writer metrics.
    • Motivation: #15370

  • Delete constructor of TxnLogBufferedWriter without parameter metrics.
    • Motivation: it is unnecessary.

  • Add a default DisabledTxnLogBufferedWriterMetricsStats implementation.

  • Previous PR remaining code to optimize: remove the check code if (metrics != null). The motivation see:
    • Motivation: https://github.com/apache/pulsar/pull/16758#discussion_r945512673

  • Make transaction log buffered writer only create by the MLTransactionMetadataStoreProvider & MLPendingAckStoreProvider.
    • Motivation: https://github.com/apache/pulsar/pull/16758#discussion_r961254161

Documentation

  • [ ] doc-required

  • [x] doc-not-needed

  • [ ] doc

  • [ ] doc-complete

Matching PR in forked repository

PR in forked repository:

  • https://github.com/poorbarcode/pulsar/pull/3

poorbarcode avatar Sep 17 '22 04:09 poorbarcode

This PR should to merge the following branches:

  • master

poorbarcode avatar Sep 17 '22 08:09 poorbarcode

/pulsarbot rerun-failure-checks

poorbarcode avatar Sep 21 '22 02:09 poorbarcode