pulsar icon indicating copy to clipboard operation
pulsar copied to clipboard

[improve][broker] Improve `retention` endpoint to pure async.

Open mattisonchao opened this issue 3 years ago • 0 comments

Motivation

Since Pulsar is a fully asynchronous project, we need to avoid using thread-blocking methods. Also, we can see https://github.com/apache/pulsar/issues/14365

Modifications

  • Improve backlogQuota relative endpoint to pure async.
  • Remove unused method validatePolicies.

Verifying this change

  • [x] Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)
  • The rest endpoints: (yes / no)
  • The admin cli options: (yes / no)
  • Anything that affects deployment: (yes / no / don't know)

Documentation

Check the box below or label this PR directly.

Need to update docs?

  • [ ] doc-required (Your PR needs to update docs and you will update later)

  • [x] doc-not-needed (Please explain why)

  • [ ] doc (Your PR contains doc changes)

  • [ ] doc-complete (Docs have been already added)

mattisonchao avatar Sep 07 '22 00:09 mattisonchao