pulsar icon indicating copy to clipboard operation
pulsar copied to clipboard

[feat] Add option to clean up all metadata.

Open MarvinCai opened this issue 3 years ago • 2 comments

Fixes https://github.com/apache/pulsar/issues/15450

Motivation

Currently after calling delete-cluster-metadata there're still metadata remain under /admin and /pulsar path which could cause trouble if zookeeper is shared between different Pulsar clusters.

Modifications

Add option to clean up topics policies and other policies and function related metadata under /admin and /pulsar when tearing down a cluster.

Verifying this change

  • [x] Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

Check the box below or label this PR directly.

Need to update docs?

  • [ ] doc-required (Your PR needs to update docs and you will update later)

  • [x] doc-not-needed doc auto generated

  • [ ] doc (Your PR contains doc changes)

  • [ ] doc-complete (Docs have been already added)

MarvinCai avatar Aug 29 '22 14:08 MarvinCai

@eolivelli Yes, we could, but that's gonna the default behavior, which might break any existing users' operation that depends on this default behavior(even it's not the desired behavior), also if a configuration meta store(global zk) is used then nuking all topic policies could also break other geo replication clusters that also using this meta store. So I'm thinking adding it as optional first. WDYT

MarvinCai avatar Aug 30 '22 02:08 MarvinCai

The pr had no activity for 30 days, mark with Stale label.

github-actions[bot] avatar Oct 20 '22 02:10 github-actions[bot]