pulsar icon indicating copy to clipboard operation
pulsar copied to clipboard

Fix default value of logSizeLimit

Open hrsakai opened this issue 3 years ago • 0 comments

Motivation

default value of logSizeLimit is 1G since bookkeeper-4.4.0 https://github.com/apache/bookkeeper/commit/10cab08d0a8b4ca4b182554dee95834dc42175d2

pulsar-2.x use bookkeeper-4.7.0 or above. https://github.com/apache/pulsar/blob/v2.0.1-incubating/pom.xml#L120

Modifications

  • Change default value of logSizeLimit(1073741824->2147483648)

Verifying this change

  • [ ] Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)
  • The rest endpoints: (yes / no)
  • The admin cli options: (yes / no)
  • Anything that affects deployment: (yes / no / don't know)

Documentation

Check the box below or label this PR directly.

Need to update docs?

  • [ ] doc-required (Your PR needs to update docs and you will update later)

  • [ ] doc-not-needed (Please explain why)

  • [ ] doc (Your PR contains doc changes)

  • [ ] doc-complete (Docs have been already added)

hrsakai avatar Aug 10 '22 00:08 hrsakai