[fix][tiered-storage] move the state check forward

[zymap]

---

Motivation

Move the close check forward to avoid getLastAddConfirmed() get an NPE. If the state is closed. That means the resource is closed and the OffloadIndexBlock has been recycled. Which will cause an NPE when getLastAddCOnfirmed().

Modifications

move the state check forward

Verifying this change

• [ ] Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

• Added integration tests for end-to-end deployment with large payloads (10MB)
• Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

• Dependencies (does it add or upgrade a dependency): (yes / no)
• The public API: (yes / no)
• The schema: (yes / no / don't know)
• The default values of configurations: (yes / no)
• The wire protocol: (yes / no)
• The rest endpoints: (yes / no)
• The admin cli options: (yes / no)
• Anything that affects deployment: (yes / no / don't know)

Documentation

Check the box below or label this PR directly.

Need to update docs?

• [ ] doc-required (Your PR needs to update docs and you will update later)

• [x] doc-not-needed (Please explain why)

• [ ] doc (Your PR contains doc changes)

• [ ] doc-complete (Docs have been already added)

[zymap]

@hangc0276 Resolved. PTAL

[github-actions[bot]]

@zymap Please provide a correct documentation label for your PR. Instructions see Pulsar Documentation Label Guide.

[github-actions[bot]]

@zymap Please provide a correct documentation label for your PR. Instructions see Pulsar Documentation Label Guide.