[fix][transaction] Correct the prompt message

[thetumbled]

Motivation

the prompt message is wrong.

Modifications

change the prompted message.

[thetumbled]

The condition checks if txnID is null,not the Positions.isn't it?

------------------ 原始邮件 ------------------ 发件人: "apache/pulsar" @.>; 发送时间: 2022年8月9日(星期二) 晚上7:32 @.>; @.@.>; 主题: Re: [apache/pulsar] Correct the prompt message (PR #17009)

@RobertIndie commented on this pull request.

In pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/pendingack/impl/PendingAckHandleImpl.java: > @@ -181,7 +181,7 @@ private void addIndividualAcknowledgeMessageRequest(TxnID txnID, public void internalIndividualAcknowledgeMessage(TxnID txnID, List<MutablePair<PositionImpl, Integer>> positions, CompletableFuture<Void> completableFuture) { if (txnID == null) { - completableFuture.completeExceptionally(new NotAllowedException("Positions can not be null.")); + completableFuture.completeExceptionally(new NotAllowedException("txnID can not be null."));
Could you explain it in more detail? Why changed here?

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were assigned.Message ID: @.***>

[github-actions[bot]]

@thetumbled Please provide a correct documentation label for your PR. Instructions see Pulsar Documentation Label Guide.

[github-actions[bot]]

@thetumbled Please provide a correct documentation label for your PR. Instructions see Pulsar Documentation Label Guide.

[Jason918]

/pulsarbot run-failure-checks

[github-actions[bot]]

The pr had no activity for 30 days, mark with Stale label.

[github-actions[bot]]

@thetumbled Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

[codecov-commenter]

Codecov Report

Merging #17009 (3645140) into master (08591d9) will decrease coverage by 2.76%. The diff coverage is 10.63%.

@@             Coverage Diff              @@
##             master   #17009      +/-   ##
============================================
- Coverage     49.85%   47.08%   -2.77%     
- Complexity     8658    10576    +1918     
============================================
  Files           500      709     +209     
  Lines         54930    69423   +14493     
  Branches       5867     7448    +1581     
============================================
+ Hits          27386    32689    +5303     
- Misses        24464    33042    +8578     
- Partials       3080     3692     +612     

Flag	Coverage Δ
unittests	47.08% <10.63%> (-2.77%)	:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...g/apache/pulsar/broker/admin/impl/TenantsBase.java	96.45% <ø> (ø)
...he/pulsar/broker/admin/v2/NonPersistentTopics.java	62.03% <ø> (ø)
...pache/pulsar/broker/admin/v2/PersistentTopics.java	74.53% <ø> (+2.84%)	:arrow_up:
...rg/apache/pulsar/broker/delayed/bucket/Bucket.java	0.00% <0.00%> (ø)
...r/delayed/bucket/BucketDelayedDeliveryTracker.java	0.00% <0.00%> (ø)
.../pulsar/broker/delayed/bucket/ImmutableBucket.java	0.00% <0.00%> (ø)
...g/apache/pulsar/broker/lookup/TopicLookupBase.java	56.89% <ø> (+6.05%)	:arrow_up:
...nsaction/pendingack/impl/PendingAckHandleImpl.java	51.15% <0.00%> (ø)
...rg/apache/pulsar/broker/web/PulsarWebResource.java	58.34% <ø> (+2.68%)	:arrow_up:
...va/org/apache/pulsar/broker/service/ServerCnx.java	48.84% <33.33%> (+1.03%)	:arrow_up:
... and 259 more

[congbobo184]

@thetumbled hi, I move this PR to release/2.9.5, if you have any questions, please ping me. thanks.

[thetumbled]

@thetumbled hi, I move this PR to release/2.9.5, if you have any questions, please ping me. thanks.

Changes have been approved by reviewers. could you merge it? thanks.

[github-actions[bot]]

The pr had no activity for 30 days, mark with Stale label.

[RobertIndie]

/pulsarbot run-failure-checks

[congbobo184]

@thetumbled hi, could you please merge the apache/master branch, seem the test can't rerun

[thetumbled]

@thetumbled hi, could you please merge the apache/master branch, seem the test can't rerun

done.