pulsar icon indicating copy to clipboard operation
pulsar copied to clipboard

[cleanup][broker] Add Maven Modernizer plugin in pulsar-broker and fix violation in `test: broker/admin`

Open youzipi opened this issue 2 years ago • 4 comments

Master Issue: #12271 #16991

Motivation

Apply Maven Modernizer plugin to enforce we move away from legacy APIs.

Modifications

Add Maven Modernizer plugin in pulsar-broker module and fix violation.

Verifying this change

This change is already covered by existing tests, such as (please describe tests).

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

  • [x] doc-not-needed

youzipi avatar Aug 08 '22 11:08 youzipi

Related to #16991 ?

tisonkun avatar Aug 08 '22 13:08 tisonkun

Related to #16991 ?

yes, I have fixed the reference.

youzipi avatar Aug 08 '22 13:08 youzipi

/pulsarbot run-failure-checks

youzipi avatar Aug 09 '22 06:08 youzipi

/pulsarbot run-failure-checks

youzipi avatar Aug 09 '22 10:08 youzipi

/pulsarbot run-failure-checks

youzipi avatar Aug 15 '22 11:08 youzipi

@youzipi It seems one required test failed. Please merge master and push for another run.

tisonkun avatar Aug 18 '22 06:08 tisonkun

/pulsarbot run-failure-checks

youzipi avatar Aug 18 '22 11:08 youzipi

/pulsarbot run-failure-checks

how to trigger the canceled checks? @tisonkun i think this command should work , according to https://github.com/apache/pulsar-test-infra/blob/master/pulsarbot/entrypoint.sh

youzipi avatar Aug 18 '22 11:08 youzipi

@youzipi https://github.com/apache/pulsar/pull/16993#issuecomment-1219396221 this comment is correct, due to CI traffic pulsarbot may queue for resources to execute. Wait a minute :)

tisonkun avatar Aug 18 '22 12:08 tisonkun

Thanks for your contribution @youzip! Go ahead.

tisonkun avatar Aug 19 '22 02:08 tisonkun