pulsar icon indicating copy to clipboard operation
pulsar copied to clipboard

[Modernizer] Apply modernizer plugin to pulsar-broker modules.

Open youzipi opened this issue 2 years ago • 2 comments

Master issue: #12271

(2022-08-08 branch=master) I scan the broker, found 617 places to change. we need to split them into multiple PRs.

- src/main: 176
- src/test:  441
  - src/test/java/org/apache/pulsar/broker: 256
    - src/test/java/org/apache/pulsar/broker/admin: 116
  - src/test/java/org/apache/pulsar/client: 181
  - src/test/java/org/apache/pulsar/common: 4

i plan to log warn first, after modify completely, turn it to error.

      <plugin>
        <groupId>org.gaul</groupId>
        <artifactId>modernizer-maven-plugin</artifactId>
        <configuration>
<!--          <failOnViolations>true</failOnViolations>-->
          <failOnViolations>false</failOnViolations>
          <javaVersion>8</javaVersion>
<!--            <violationLogLevel>error</violationLogLevel>-->
          <violationLogLevel>warn</violationLogLevel>
        </configuration>
        <executions>
          <execution>
            <id>modernizer</id>
            <phase>verify</phase>
            <goals>
              <goal>modernizer</goal>
            </goals>
          </execution>
        </executions>
      </plugin>

youzipi avatar Aug 08 '22 11:08 youzipi

@MarvinCai @tisonkun @codelipenghui I will start from test .. broker/admin

youzipi avatar Aug 08 '22 11:08 youzipi

Go ahead!

@MarvinCai could you help on updating #12271 that pulsar-broker is taken by @youzipi?

tisonkun avatar Aug 08 '22 13:08 tisonkun

The issue had no activity for 30 days, mark with Stale label.

github-actions[bot] avatar Sep 08 '22 02:09 github-actions[bot]

The remaining packages are:

            <ignorePackage>org.apache.pulsar.broker.admin</ignorePackage>
            <ignorePackage>org.apache.pulsar.broker.namespace</ignorePackage>
            <ignorePackage>org.apache.pulsar.broker.service</ignorePackage>
            <ignorePackage>org.apache.pulsar.broker.stats</ignorePackage>

Thank you @youzipi and go ahead!

tisonkun avatar Sep 15 '22 11:09 tisonkun

@MarvinCai @codelipenghui @nodece should be closed by #17968.

tisonkun avatar Oct 13 '22 09:10 tisonkun