pulsar
pulsar copied to clipboard
[Modernizer] Apply modernizer plugin to pulsar-broker modules.
Master issue: #12271
(2022-08-08 branch=master) I scan the broker, found 617 places to change. we need to split them into multiple PRs.
- src/main: 176
- src/test: 441
- src/test/java/org/apache/pulsar/broker: 256
- src/test/java/org/apache/pulsar/broker/admin: 116
- src/test/java/org/apache/pulsar/client: 181
- src/test/java/org/apache/pulsar/common: 4
i plan to log warn
first, after modify completely, turn it to error
.
<plugin>
<groupId>org.gaul</groupId>
<artifactId>modernizer-maven-plugin</artifactId>
<configuration>
<!-- <failOnViolations>true</failOnViolations>-->
<failOnViolations>false</failOnViolations>
<javaVersion>8</javaVersion>
<!-- <violationLogLevel>error</violationLogLevel>-->
<violationLogLevel>warn</violationLogLevel>
</configuration>
<executions>
<execution>
<id>modernizer</id>
<phase>verify</phase>
<goals>
<goal>modernizer</goal>
</goals>
</execution>
</executions>
</plugin>
@MarvinCai @tisonkun @codelipenghui
I will start from test .. broker/admin
Go ahead!
@MarvinCai could you help on updating #12271 that pulsar-broker is taken by @youzipi?
The issue had no activity for 30 days, mark with Stale label.
The remaining packages are:
<ignorePackage>org.apache.pulsar.broker.admin</ignorePackage>
<ignorePackage>org.apache.pulsar.broker.namespace</ignorePackage>
<ignorePackage>org.apache.pulsar.broker.service</ignorePackage>
<ignorePackage>org.apache.pulsar.broker.stats</ignorePackage>
Thank you @youzipi and go ahead!
@MarvinCai @codelipenghui @nodece should be closed by #17968.