pulsar icon indicating copy to clipboard operation
pulsar copied to clipboard

Published 20 hours ago • verified publisher icon apache

[test]Fix Flaky-test: BrokerServiceTest.testLookupThrottlingForClientByClient

Open AnonHxy opened this issue 2 years ago • 7 comments

Master Issue: https://github.com/apache/pulsar/issues/16521

Motivation

  • Fixes https://github.com/apache/pulsar/issues/16521

  • If the broker responds quickly enough, there may never be concurrency in requests, so we use a Semaphore to block the response.

Modifications

Fix UT BrokerServiceTest.testLookupThrottlingForClientByClient

Verifying this change

  • [x] Make sure that the change passes the CI checks.

Documentation

Check the box below or label this PR directly.

Need to update docs?

  • [ ] doc-required (Your PR needs to update docs and you will update later)

  • [x] doc-not-needed (Please explain why)

  • [ ] doc (Your PR contains doc changes)

  • [ ] doc-complete (Docs have been already added)

AnonHxy avatar Jul 12 '22 09:07 AnonHxy

/pulsarbot run-failure-checks

AnonHxy avatar Jul 12 '22 10:07 AnonHxy

/pulsarbot run-failure-checks

AnonHxy avatar Jul 12 '22 12:07 AnonHxy

/pulsarbot run-failure-checks

Technoboy- avatar Jul 12 '22 13:07 Technoboy-

Close this PR because this flaky test has already been fixed

AnonHxy avatar Jul 13 '22 02:07 AnonHxy

@poorbarcode Could you please review this PR?

codelipenghui avatar Aug 08 '22 13:08 codelipenghui

left a comment:

I feel the origin log "At least one should fail" is better

Updated

AnonHxy avatar Aug 10 '22 06:08 AnonHxy

@codelipenghui @Technoboy- PTAL also~

AnonHxy avatar Aug 10 '22 06:08 AnonHxy

/pulsarbot run-failure-checks

AnonHxy avatar Aug 10 '22 12:08 AnonHxy