pulsar icon indicating copy to clipboard operation
pulsar copied to clipboard

[fix][function]Let packagesManagement start before function work service

Open liangyuanpeng opened this issue 3 years ago • 5 comments

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #

Master Issue: #

Motivation

Pulsar Function will run failed when pulsar standalone restart, the reason is function work service start before package management service.

Had enable package management and got the error of Package Management Service is not enabled in the broker.

lanrendeMacBook-Pro:~ lanren$ pulsarctl functions status --name win
{
  "numInstances": 1,
  "numRunning": 0,
  "instances": [
    {
      "instanceId": 0,
      "status": {
        "running": false,
        "error": "Package Management Service is not enabled in the broker.",
        "numRestarts": 0,
        "numReceived": 0,
        "numSuccessfullyProcessed": 0,
        "numUserExceptions": 0,
        "latestUserExceptions": null,
        "numSystemExceptions": 0,
        "latestSystemExceptions": null,
        "averageLatency": 0,
        "lastInvocationTime": 0,
        "workerId": "c-standalone-fw-localhost-8080"
      }
    }
  ]
}

Modifications

Let package management service start before function work service.

Verifying this change

  • [ ] Make sure that the change passes the CI checks.
  1. run pulsar standalone
  2. create function
  3. restart pulsar standalone
  4. check function status

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)
  • The rest endpoints: (yes / no)
  • The admin cli options: (yes / no)
  • Anything that affects deployment: (yes / no / don't know)

Documentation

Check the box below or label this PR directly.

Need to update docs?

  • [ ] doc-required (Your PR needs to update docs and you will update later)

  • [x] doc-not-needed

Bug Fix

  • [ ] doc (Your PR contains doc changes)

  • [ ] doc-complete (Docs have been already added)

liangyuanpeng avatar Jul 10 '22 02:07 liangyuanpeng

Absolutely, i will add some test.

liangyuanpeng avatar Jul 13 '22 14:07 liangyuanpeng

The pr had no activity for 30 days, mark with Stale label.

github-actions[bot] avatar Aug 25 '22 02:08 github-actions[bot]

@liangyuanpeng hi, I move this PR to release/2.9.5, if you have any questions, please ping me. thanks.

congbobo184 avatar Nov 17 '22 12:11 congbobo184

The pr had no activity for 30 days, mark with Stale label.

github-actions[bot] avatar Dec 19 '22 01:12 github-actions[bot]

As discussed on the mailing list https://lists.apache.org/thread/w4jzk27qhtosgsz7l9bmhf1t7o9mxjhp, there is no plan to release 2.9.6, so I am going to remove the release/2.9.6 label

michaeljmarshall avatar Jun 27 '23 21:06 michaeljmarshall