pulsar icon indicating copy to clipboard operation
pulsar copied to clipboard
verified publisher icon apache

[improve][broker][monitoring] metrics data flow control

Open tjiuming opened this issue 3 years ago • 4 comments

Motivation

add metrics data flow control when Prometheus scrape metrics, to prevent high network usage.

Modifications

  1. add MetricsDataFlowController class
  2. add metricsDataFlowPermitPerSecond configuration

Documentation

Check the box below or label this PR directly.

Need to update docs?

  • [x] doc-required (Your PR needs to update docs and you will update later)

  • [ ] doc-not-needed (Please explain why)

  • [ ] doc (Your PR contains doc changes)

  • [ ] doc-complete (Docs have been already added)

tjiuming avatar Jul 07 '22 19:07 tjiuming

/pulsarbot run-failure-checks

tjiuming avatar Jul 08 '22 18:07 tjiuming

What's case we need this? IMO, it should be working on some proxy.

if there is a big metrics response, say, 500MB, without flow control, it will comes high network usage and high messaging latency

tjiuming avatar Jul 11 '22 04:07 tjiuming

@tjiuming It's better to start a discussion in the mailing list since it's a new feature for the Prometheus endpoint.

codelipenghui avatar Jul 20 '22 07:07 codelipenghui

The pr had no activity for 30 days, mark with Stale label.

github-actions[bot] avatar Aug 20 '22 02:08 github-actions[bot]