pulsar icon indicating copy to clipboard operation
pulsar copied to clipboard

[fix][client-tool]fix the topic offload policy param will be covered unexpected.

Open Nicklee007 opened this issue 2 years ago • 4 comments

Motivation

Compare the namespace offload policy, the topic offload policy command line update function use int and long type to accept param and miss some param check method, which will cause the param value set as 0 if the param is missed.

Modifications

  1. use String to accept param and add some check.
  2. Set a default value if the param is not set, and will check if is default value in PersistentTopicsBase.
  3. NamespacesBase and some check.

Documentation

  • [X] doc-need

Nicklee007 avatar Jul 03 '22 07:07 Nicklee007

/pulsarbot run-failure-checks

Nicklee007 avatar Jul 20 '22 09:07 Nicklee007

The pr had no activity for 30 days, mark with Stale label.

github-actions[bot] avatar Sep 08 '22 02:09 github-actions[bot]

Since we will start the RC version of 3.0.0 on 2023-04-11, I will change the label/milestone of PR who have not been merged.

  • The PR of type feature is deferred to 3.1.0
  • The PR of type fix is deferred to 3.0.1

So drag this PR to 3.0.1

poorbarcode avatar Apr 10 '23 14:04 poorbarcode

@Nicklee007 Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

github-actions[bot] avatar Apr 10 '23 14:04 github-actions[bot]