pulsar icon indicating copy to clipboard operation
pulsar copied to clipboard
verified publisher icon apache

fix: make internalSetMaxConsumersPerSubscription async

Open leizhiyuan opened this issue 3 years ago • 4 comments

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #15856

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications

Describe the modifications you've done.

Verifying this change

  • [ ] Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)
  • The rest endpoints: (yes / no)
  • The admin cli options: (yes / no)
  • Anything that affects deployment: (yes / no / don't know)

Documentation

Check the box below or label this PR directly.

Need to update docs?

  • [ ] doc-required (Your PR needs to update docs and you will update later)

  • [ ] doc-not-needed (Please explain why)

  • [ ] doc (Your PR contains doc changes)

  • [ ] doc-complete (Docs have been already added)

leizhiyuan avatar May 31 '22 09:05 leizhiyuan

@leizhiyuan:Thanks for your contribution. For this PR, do we need to update docs? (The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

github-actions[bot] avatar May 31 '22 10:05 github-actions[bot]

@mattisonchao We need to be connected to #15043 ?

shibd avatar May 31 '22 15:05 shibd

@mattisonchao We need to be connected to #15043 ?

I didn't notice that before, It seems that someone is working on this issue. maybe I can wait for that

leizhiyuan avatar May 31 '22 23:05 leizhiyuan

The pr had no activity for 30 days, mark with Stale label.

github-actions[bot] avatar Jul 07 '22 02:07 github-actions[bot]

Since it takes a long time and the code differences are too large, I will close this PR.

leizhiyuan avatar Oct 15 '24 02:10 leizhiyuan