pulsar icon indicating copy to clipboard operation
pulsar copied to clipboard

[fix][broker] fix ns total size stats

Open leizhiyuan opened this issue 3 years ago • 13 comments

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #15492

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications

Describe the modifications you've done.

Verifying this change

  • [ ] Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)
  • The rest endpoints: (yes / no)
  • The admin cli options: (yes / no)
  • Anything that affects deployment: (yes / no / don't know)

Documentation

Check the box below or label this PR directly.

Need to update docs?

  • [ ] doc-required (Your PR needs to update docs and you will update later)

  • [x] no-need-doc (Please explain why)

  • [ ] doc (Your PR contains doc changes)

  • [ ] doc-added (Docs have been already added)

leizhiyuan avatar May 09 '22 03:05 leizhiyuan

@leizhiyuan:Thanks for your contribution. For this PR, do we need to update docs? (The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

github-actions[bot] avatar May 09 '22 03:05 github-actions[bot]

@leizhiyuan:Thanks for providing doc info!

github-actions[bot] avatar May 09 '22 03:05 github-actions[bot]

LGTM

tjiuming avatar May 09 '22 03:05 tjiuming

#15492

maybe we should confirm that size should multiplied by the number of replicas or not?

leizhiyuan avatar May 11 '22 07:05 leizhiyuan

The pr had no activity for 30 days, mark with Stale label.

github-actions[bot] avatar Jul 10 '22 02:07 github-actions[bot]

@michaeljmarshall Any further suggestions about this PR?

Jason918 avatar Aug 27 '22 08:08 Jason918

@Jason918 I think that @michaeljmarshall suggestion is correct and we should go that way

eolivelli avatar Aug 27 '22 09:08 eolivelli

The pr had no activity for 30 days, mark with Stale label.

github-actions[bot] avatar Sep 27 '22 02:09 github-actions[bot]

@leizhiyuan hi, I move this PR to release/2.9.5, if you have any questions, please ping me. thanks.

congbobo184 avatar Nov 17 '22 12:11 congbobo184

@leizhiyuan Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

github-actions[bot] avatar Nov 17 '22 12:11 github-actions[bot]

The pr had no activity for 30 days, mark with Stale label.

github-actions[bot] avatar Dec 20 '22 02:12 github-actions[bot]

Since we will start the RC version of 3.0.0 on 2023-04-11, I will change the label/milestone of PR who have not been merged.

  • The PR of type feature is deferred to 3.1.0
  • The PR of type fix is deferred to 3.0.1

So drag this PR to 3.0.1

poorbarcode avatar Apr 10 '23 08:04 poorbarcode

As discussed on the mailing list https://lists.apache.org/thread/w4jzk27qhtosgsz7l9bmhf1t7o9mxjhp, there is no plan to release 2.9.6, so I am going to remove the release/2.9.6 label

michaeljmarshall avatar Jun 27 '23 21:06 michaeljmarshall

Since it takes a long time and the code differences are too large, I will close this PR.

leizhiyuan avatar Oct 15 '24 02:10 leizhiyuan