apache
[fix] [broker] Disabled deduplication, but ledger-store will not be d…
Motivation
When execute command ulsar-admin topicPolicies get-deduplication persistent://{tenant}/{ns}/{topic} failure.
Then the deduplication task will be disabled, and cursor 'pulsar.dedup' will not move still restart broker.
But zk-node: /managed-ledgers/{tenant}/{ns}/persistent/{topic}/pulsar.dedup still exists.
Errors occur: this topic's ledger-store will not be deleted anymore, even if all message has been acknowledged.
Modifications
- When
checkDeduplicationStatus()failure, stop this topic. - Rewrite the state change of
MessageDeduplication
Documentation
Need to update docs?
-
[ ]
doc-required -
[x]
no-need-doc -
[ ]
doc -
[ ]
doc-added
Little question: I'm not sure if the issue is unrecoverable, but it feels a little bad to close the topic. Please let me know what you think.
Another question: Can we add tests to verify this issue?
OK. Thank you for reminding me. liang zai
Little question: I'm not sure if the issue is unrecoverable, but it feels a little bad to close the topic. Please let me know what you think.
I'm not sure if the issue is unrecoverable, but it feels a little bad to close the topic.
If deduplication can't work properly, means topic can't work properly.
When user changes deduplication status, it should be clear that works or not.
Do close topic will rerty start deduplication task or told user topic was done, both of these results are useful to user
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
@poorbarcode Please provide a correct documentation label for your PR. Instructions see Pulsar Documentation Label Guide.
@poorbarcode Please provide a correct documentation label for your PR. Instructions see Pulsar Documentation Label Guide.
@poorbarcode Please provide a correct documentation label for your PR. Instructions see Pulsar Documentation Label Guide.
@poorbarcode hi, I move this PR to release/2.9.5, if you have any questions, please ping me. thanks.
As discussed on the mailing list https://lists.apache.org/thread/w4jzk27qhtosgsz7l9bmhf1t7o9mxjhp, there is no plan to release 2.9.6, so I am going to remove the release/2.9.6 label
