pulsar icon indicating copy to clipboard operation
pulsar copied to clipboard

[fix][CI] Check Pulsar SQL / Trino license files

Open lhotari opened this issue 3 years ago • 5 comments

Fixes #16783

Motivation

The new "Pulsar CI" workflow doesn't currently check Pulsar SQL (Trino) license files. The existing "build-and-license-check" builds only the core-modules profile because of performance reasons.

Modifications

Add license check to the step that builds the full apachepulsar/pulsar-test-latest-version:latest docker image.

lhotari avatar Apr 21 '22 11:04 lhotari

The pr had no activity for 30 days, mark with Stale label.

github-actions[bot] avatar May 23 '22 02:05 github-actions[bot]

The pr had no activity for 30 days, mark with Stale label.

github-actions[bot] avatar Jun 22 '22 02:06 github-actions[bot]

@tisonkun Please review

lhotari avatar Sep 15 '22 06:09 lhotari

@lhotari Please provide a correct documentation label for your PR. Instructions see Pulsar Documentation Label Guide.

github-actions[bot] avatar Sep 15 '22 06:09 github-actions[bot]

I don't know if you did it on purpose but running this check also in the Build and License check step is a good thing because it can avoid unnecessary steps to be executed in case of failure

@nicoloboschi @tisonkun It's intentionally not handled in "Build and License check". if it would be done there, we'd have to compile the whole distribution and that would mess up the whole "Build and License check" step.

lhotari avatar Sep 19 '22 12:09 lhotari

@lhotari any progress here?

tisonkun avatar Oct 17 '22 10:10 tisonkun

No responses. Try to supersede in #18171.

tisonkun avatar Oct 24 '22 06:10 tisonkun