pulsar icon indicating copy to clipboard operation
pulsar copied to clipboard

[Functions] Enable poolMessages of functions by default

Open wangjialing218 opened this issue 4 years ago • 3 comments

Motivation

We have introduced poolMessages for consumer by PIP-83, and add configuration for functions by #11618 The default value of poolMessage is false if user did not config it in FunctionConfig.

It's better to enable poolMessage for function instance to avoid high work load of JVM GC. And user do not need to call release API for each messages, we have already did that in function instance side. For those user developing functions, they do not need to known the detail of memory usage with poolMessage and whether they need to enable poolMessage when create functions.

Modifications

Enable poolMessages of functions by default

Verifying this change

This change is already covered by existing tests, such as testPoolMessages()

Documentation

Check the box below and label this PR (if you have committer privilege).

Need to update docs?

  • [x] no-need-doc

    Only change default value

wangjialing218 avatar Dec 13 '21 06:12 wangjialing218

The failed test testPulsarSinkDLQ seems caused by a existed issue, I have record the detail in #13269

wangjialing218 avatar Dec 13 '21 09:12 wangjialing218

The pr had no activity for 30 days, mark with Stale label.

github-actions[bot] avatar Feb 26 '22 01:02 github-actions[bot]

The pr had no activity for 30 days, mark with Stale label.

github-actions[bot] avatar May 30 '22 02:05 github-actions[bot]