pulsar icon indicating copy to clipboard operation
pulsar copied to clipboard

Published 20 hours ago • verified publisher icon apache

[feat] [pulsar-admin] Add remove-clusters command for namespace

Open yuruguo opened this issue 4 years ago • 8 comments

From dev-email Fixes #12822

Motivation

CLI bin/pulsar-admin supports set-clusters and get-clusters command, but lacks corresponding remove-clusters commands, the purpose of this PR is to add this command.

Documentation

Automatically generate doc through code

  • [x] doc

yuruguo avatar Oct 13 '21 15:10 yuruguo

@yuruguo Can you add a test to make sure all the clusters of a namespace can be removed and the topic can still work for publishing and consumption?

codelipenghui avatar Oct 14 '21 07:10 codelipenghui

@yuruguo Can you add a test to make sure all the clusters of a namespace can be removed and the topic can still work for publishing and consumption?

Have added this test, PTAL.

yuruguo avatar Oct 15 '21 13:10 yuruguo

@yuruguo we are adding more and more new REST endpoints in order to support this set of commands for pulsar-admin.

What about creating a list of the features that you want to implement and discuss it with the community.

The risk is to add more and more APIs without control and discussions in the community.

eolivelli avatar Nov 15 '21 12:11 eolivelli

@eolivelli @codelipenghui @315157973 Sorry, Could you review this pr again? I have addressed all comments :)

yuruguo avatar Dec 17 '21 04:12 yuruguo

@eolivelli @codelipenghui @315157973 Sorry, Could you review this pr again? I have addressed all comments :)

Please follow eolivelli‘s comment. It may be a risk is to add more and more APIs without control and should discuss in the community.

315157973 avatar Dec 17 '21 06:12 315157973

@eolivelli @codelipenghui @315157973 Sorry, Could you review this pr again? I have addressed all comments :)

Please follow eolivelli‘s comment. It may be a risk is to add more and more APIs without control and should discuss in the community.

Thanks for your reply, I have created a related issue and sent an email to the dev mailing list to discuss it. Maybe there are other tasks I am happy to do :)

yuruguo avatar Dec 17 '21 07:12 yuruguo

The pr had no activity for 30 days, mark with Stale label.

github-actions[bot] avatar Feb 28 '22 01:02 github-actions[bot]

Since we will start the RC version of 3.0.0 on 2023-04-11, I will change the label/milestone of PR who have not been merged.

  • The PR of type feature is deferred to 3.1.0
  • The PR of type fix is deferred to 3.0.1

So drag this PR to 3.1.0

poorbarcode avatar Apr 10 '23 07:04 poorbarcode