pulsar-manager icon indicating copy to clipboard operation
pulsar-manager copied to clipboard

Support HerdDB in the standard docker image.

Open mattisonchao opened this issue 3 years ago • 4 comments

Motivation

Now, The docker image starts PostGRE, and it is a waste of resources. So, we can to use HerdDB instead.

Some code link: https://github.com/apache/pulsar-manager/blob/73e4ae37cdab1d8f1f6c08fd5aaca91c612687b6/docker/startup.sh

mattisonchao avatar Jan 14 '22 07:01 mattisonchao

I'm current work on it.

mattisonchao avatar Jan 14 '22 07:01 mattisonchao

@mattisonchao - what do you think about making it configurable to skip the spawning of any database process in the docker image? Then, in the Pulsar Helm Chart, we could add configuration to make it possible to add the database as a container in the Pulsar Manager's pod. That allows for better visibility into processes that the pod is running and it would also make it the database a bit more configurable.

michaeljmarshall avatar Jan 23 '22 05:01 michaeljmarshall

@michaeljmarshall

Yes, That's exactly what I thought.

I think we can add herddb image in docker-compose and remove raw database logic from pulsar-manager to improve user experience and observability.

Am I understanding right?

mattisonchao avatar Jan 23 '22 14:01 mattisonchao

@mattisonchao - yes, that makes sense to me for docker-compose. Ideally, we will also make it configurable in the pulsar helm chart.

michaeljmarshall avatar Jan 24 '22 18:01 michaeljmarshall