pulsar-helm-chart icon indicating copy to clipboard operation
pulsar-helm-chart copied to clipboard

pulsar-proxy: tls Certname

Open cccdemon opened this issue 1 year ago • 4 comments

Is your feature request related to a problem? Please describe. When you want to use a valid / signed certificate for pulsar-proxy, the helm charts do not use the certname you entered in the values file: Example: proxy: enabled: true cert_name: my-valid-certificate # use this certname createCert: false # set to false if you want to use an existing certificate

Results in certificate name within the Proxy as "pulsar-my-valid-certificate"

Describe the solution you'd like just use the cert_name i`ve entered

Describe alternatives you've considered remove the option of "using the releasename as prefix"

Additional context File: proxy-statefulset.yaml

{{- if .Values.tls.proxy.createCert }}
secretName: "{{ .Release.Name }}-{{ .Values.tls.proxy.cert_name }}"
{{- else }}
secretName: "{{ .Values.tls.proxy.cert_name }}"
{{- end }}

cccdemon avatar Sep 11 '24 12:09 cccdemon

@cccdemon Sounds like a useful improvement. Would you like to contribute a pull request? This Helm chart is community maintained so pull requests are preferred so that we can improve the chart together over time.

lhotari avatar Sep 19 '24 04:09 lhotari

@lhotari never did that, but I will give it a try :-)

cccdemon avatar Sep 24 '24 08:09 cccdemon

@cccdemon There's #523 with a related change. That has been merged.

lhotari avatar Oct 18 '24 07:10 lhotari

There's also #561

lhotari avatar Dec 18 '24 09:12 lhotari