pulsar-helm-chart icon indicating copy to clipboard operation
pulsar-helm-chart copied to clipboard

Fix PodMonitor name conflicts for multiple releases in same namespace

Open LoveEachDay opened this issue 2 years ago • 1 comments

Signed-off-by: Edward Zeng [email protected]

Fixes #257

Motivation

Fix PodMonitor name conflicts for multiple releases in same namespace

Modifications

Use release name instead of hardcode pulsar.name for pod monitor name.

Verifying this change

  • [x] Make sure that the change passes the CI checks.

LoveEachDay avatar Apr 12 '22 10:04 LoveEachDay

/cc @tuteng

LoveEachDay avatar Apr 12 '22 10:04 LoveEachDay

In order to include this in the upcoming release, I committed my suggestion.

michaeljmarshall avatar Oct 20 '22 04:10 michaeljmarshall

We failed the lint-test for the previous commit due to an unexpected error. I merged master into this branch to get the latest tests to run.

michaeljmarshall avatar Oct 20 '22 04:10 michaeljmarshall

Closing and re-opening to get the latest changes to the CI pipeline.

michaeljmarshall avatar Oct 20 '22 18:10 michaeljmarshall