pulsar-helm-chart icon indicating copy to clipboard operation
pulsar-helm-chart copied to clipboard

allow specifying the nodeSelector for the init jobs

Open elangelo opened this issue 3 years ago • 2 comments

Fixes #

Motivation

When deploying pulsar to an AKS cluster with windows nodepools i was unable to specify that the Jobs of the initalize release had to run on linux nodes. With the change i can now specify a node selector for the init jobs.

Modifications

add nodeSelector on pulsar_init and bookie_init

Verifying this change

  • [ ] Make sure that the change passes the CI checks.

elangelo avatar Feb 07 '22 14:02 elangelo

Thanks for the PR. Would it be possible to use the key pulsar_metadata.nodeSelector instead of initialize_jobs.nodeSelector? Please also add a placeholder in the default values.yaml with a comment documenting the setting. The value should be empty.

what do i do for the bookkeeper_cluster_initalize jobs? specify another nodeSelector value? or use the pulsar_metadata.nodeSelector value there as well?

elangelo avatar Feb 08 '22 16:02 elangelo

what do i do for the bookkeeper_cluster_initalize jobs? specify another nodeSelector value? or use the pulsar_metadata.nodeSelector value there as well?

I think it's fine to use the pulsar_metadata.nodeSelector value there as well.

lhotari avatar Feb 09 '22 09:02 lhotari

Thanks for your contribution @elangelo!

michaeljmarshall avatar Oct 20 '22 04:10 michaeljmarshall