pulsar-helm-chart icon indicating copy to clipboard operation
pulsar-helm-chart copied to clipboard
verified publisher icon apache

Use appVersion as default tag for Pulsar images

Open lhotari opened this issue 3 years ago • 3 comments

Motivation

There was a suggestion in a dev mailing list discussion that the Helm chart's appVersion should be used as the default image tag.

Additional context

There are some limitations in Helm. It is not possible to set "appVersion" from the command line. There's in an open feature request https://github.com/helm/helm/issues/8194 to add such a feature to Helm.

Modifications

  • change default values.yaml and set the tags for the images that use the Pulsar image to an empty value
  • add "defaultPulsarImageTag" to values.yaml
  • add a helper template "pulsar.imageFullName" that contains the logic to fall back to .Values.defaultPulsarImageTag and if it's not set, falling back to .Chart.AppVersion
  • use the helper template in all other templates that require the logic

lhotari avatar Jan 12 '22 12:01 lhotari

@lhotari just to confirm - for those of us who have overridden the tag that functionality will remain unchanged? Thanks!

frankjkelly avatar Jan 20 '22 16:01 frankjkelly

@lhotari just to confirm - for those of us who have overridden the tag that functionality will remain unchanged? Thanks!

@frankjkelly yes, the intention is to be backwards compatible.

lhotari avatar Jan 20 '22 18:01 lhotari

@sijie please review this PR since it's based on your suggestion the dev mailing list. I might have misunderstood your suggestion.

lhotari avatar Jan 26 '22 14:01 lhotari