pulsar-client-node icon indicating copy to clipboard operation
pulsar-client-node copied to clipboard

[feature request] Support batch receive and ack

Open shibd opened this issue 3 years ago • 5 comments

Motivation

You can refer to PIP-38.

Solution

We already support batch receive in the C++ client https://github.com/apache/pulsar-client-cpp/pull/21, In the Node.js client side, we can wrap its interface for support.

shibd avatar Jan 03 '23 08:01 shibd

Hi @shibd - was trying to give this a go and notice there are no methods regarding the new batching implementation in https://github.com/apache/pulsar-client-cpp/blob/main/lib/c/c_Consumer.cc

I was thinking the implementation would follow a similar pattern of calling methods found there in https://github.com/apache/pulsar-client-node/blob/master/src/Consumer.cc - am I completely off the mark?

Also would this implementation still require the use of ConsumerReceiveWorker? Thanks

mguay22 avatar Feb 22 '23 19:02 mguay22

any updates?

HasanHaghniya avatar Mar 17 '23 08:03 HasanHaghniya

was trying to give this a go and notice there are no methods regarding the new batching implementation in https://github.com/apache/pulsar-client-cpp/blob/main/lib/c/c_Consumer.cc

Yes, we need to support the batch receive method on the c interface first.

shibd avatar Mar 18 '23 02:03 shibd

I saw that #357 was merged — I'm curious when the next release of the Nodejs Pulsar client might be? Or is there an outstanding todo for batch receive?

Thanks for all your contributions. 🙂

samwaterbury avatar Jan 22 '24 02:01 samwaterbury

Looks like this just landed in v1.10.0. Thank you! We're eager to try it out and see performance benefits from the batching.

mguay22 avatar Feb 06 '24 15:02 mguay22