pulsar-client-go icon indicating copy to clipboard operation
pulsar-client-go copied to clipboard

Update github.com/golang-jwt/jwt to v4

Open ItalyPaleAle opened this issue 2 years ago • 2 comments

Motivation

This project depended on the v3 of github.com/golang-jwt/jwt. All new versions of the library are now released with the go.mod-enabled github.com/golang-jwt/jwt/v4 import path (although there are no breaking changes from v3).

This is a security-related library and being on the latest version ensures that any security fix can be applied quickly.

Modifications

Updated the golang-jwt library to v4.

Verifying this change

  • [X] Make sure that the change passes the CI checks.

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): yes
  • The public API: no
  • The schema: no
  • The default values of configurations: no
  • The wire protocol: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable
  • If a feature is not applicable for documentation, explain why? Internal change only
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

ItalyPaleAle avatar Feb 16 '23 01:02 ItalyPaleAle

@ItalyPaleAle Any updates?

nodece avatar Feb 23 '23 08:02 nodece

@nodece my apologies, I disabled notifications for when CI fails (because I was getting spammed) so I didn't get alerted.

The CI is failing because it's trying to run tests using Go 1.16, but the go.mod file says that the minimum version is 1.18. I don't think it's an issue I can fix here :(

ItalyPaleAle avatar Feb 23 '23 18:02 ItalyPaleAle

Closed by https://github.com/apache/pulsar-client-go/pull/1214

nodece avatar May 11 '24 14:05 nodece