pulsar-client-go icon indicating copy to clipboard operation
pulsar-client-go copied to clipboard

Published 20 hours ago • verified publisher icon apache

[client] rewrite regexConsumer to avoid duplicate code

Open labuladong opened this issue 2 years ago • 2 comments

Fixes #846

Verifying this change

  • [x] Make sure that the change passes the CI checks.

This change is already covered by existing tests, such as consumer_regex_test.go.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • The public API: (yes)
  • The schema: (don't know)
  • The default values of configurations: (no)
  • The wire protocol: (no)

Modifications

Reuse multiTopicConsumer in regexConsumer to avoid duplicate code.

labuladong avatar Sep 16 '22 08:09 labuladong

cc @nodece @RobertIndie @wolfstudy

labuladong avatar Sep 16 '22 09:09 labuladong

Conflict resolved, ready to merge.

labuladong avatar Oct 11 '22 05:10 labuladong

Ping @labuladong

nodece avatar Nov 29 '22 04:11 nodece

Conflict resolved. #805 does the same change in regexConsumer and multiTopicConsumer, so this PR is still compatible.

labuladong avatar Nov 29 '22 05:11 labuladong

Can this pr be merged? @nodece @Gleiphir2769 @RobertIndie

labuladong avatar Nov 29 '22 06:11 labuladong