pulsar-client-go icon indicating copy to clipboard operation
pulsar-client-go copied to clipboard

Published 20 hours ago • verified publisher icon apache

Check ParseTopicName() return err

Open EAHITechnology opened this issue 4 years ago • 3 comments

EAHITechnology avatar May 13 '21 13:05 EAHITechnology

@EAHITechnology Any update for this?

wolfstudy avatar Jun 02 '21 02:06 wolfstudy

I think we already tested the topics with func validateTopicNames(topics ...string) ([]*internal.TopicName, error), so could you please fill this PR's content to help us understand the context and what issue is trying to solve? thanks.

freeznet avatar Jun 02 '21 06:06 freeznet

I think we already tested the topics with func validateTopicNames(topics ...string) ([]*internal.TopicName, error), so could you please fill this PR's content to help us understand the context and what issue is trying to solve? thanks.

hello @freeznet In ParseTopicName, we threw an error, but during the call, we ignored the error. such as:

in filterTopics

tn, _ := internal.ParseTopicName(t)

in GetTopicMetrics:

tn, _ := ParseTopicName(t)

wolfstudy avatar Jun 03 '21 03:06 wolfstudy