pulsar-client-cpp icon indicating copy to clipboard operation
pulsar-client-cpp copied to clipboard

Upgrade vcpkg dependencies for the missed boost-format dependency

Open BewareMyPower opened this issue 1 year ago • 4 comments

Motivation

See https://github.com/microsoft/vcpkg/pull/36510

Currently the commit id of the vcpkg submodule is old. With latest dependencies in vcpkg, it requires a boost-format dependency to build.

Modifications

Upgrade the vcpkg submodule to the latest commit at the moment and add the boost-format dependency to fix the build.

BewareMyPower avatar Jun 11 '24 09:06 BewareMyPower

There are some failed tests. I'm going to check if they were introduced by an upgraded dependency

BewareMyPower avatar Jun 11 '24 15:06 BewareMyPower

It's an issue with the JSON serialization for key-value schema. Maybe caused by the boost.property_tree dependency.

BewareMyPower avatar Jun 11 '24 15:06 BewareMyPower

The root cause is that latest's Boost.PropertyTree does not write a line ending in write_json. So I updated the Boost version to 1.85 in dependencies.yaml as well to avoid behavior inconsistency.

BewareMyPower avatar Jun 12 '24 03:06 BewareMyPower

There is a bug for GCC 4.8 that it does not support std::align, which is a standard of C++11.

I sent an email to drop GCC 4.8 in the next release (see https://lists.apache.org/thread/7o8hpv1gtoffvzx053wm0ss2s9xt0795), so I will open a PR to drop the support for GCC 4.8 first and then go back to this PR.

BewareMyPower avatar Jun 13 '24 14:06 BewareMyPower