fix: doCommitOffsets of PulsarKafkaConsumer in version 2.11.0
Fixes #48
Master Issue: #48
Motivation
doCommitOffsets method in Pulsar Kafka Client version 2.11.0 is not working for partitioned topics. This does not allows acking messages.
Modifications
In doCommitOffsets PulsarKafkaConsumer.java creating TopicMessageIdImpl with the correct partition name
Verifying this change
- [ ] Make sure that the change passes the CI checks.
This change is already covered by existing tests, provided we create it as a partitioned topic
Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API: (no)
- The schema: (no)
- The default values of configurations: (no)
- The wire protocol: (no)
- The rest endpoints: (no)
- The admin cli options: (no)
- Anything that affects deployment: (no)
Documentation
- Does this pull request introduce a new feature? (no)
@eolivelli @dlg99 added a unit test for commitSync, specifically on how acknowledgeCumulativeAsync is called inside doCommitOffsets. Let me know if there is any thing else required.
@dlg99, any idea when can this be merged if everything is good? Also, can a patch version be released with this fix ?
I support to merge this patch. @dlg99 @eolivelli could you give another look?