poi icon indicating copy to clipboard operation
poi copied to clipboard

Spelling

Open jsoref opened this issue 2 years ago • 6 comments

This PR corrects misspellings identified by the check-spelling action.

The misspellings have been reported at https://github.com/jsoref/poi/actions/runs/5360105495#summary-14513021500

The action reports that the changes in this PR would make it happy: https://github.com/check-spelling/poi/actions/runs/5360101471#summary-14513009039

jsoref avatar Jun 23 '23 20:06 jsoref

It's possible everything else is ok. I'm done for the weekend. I'll check back sometime next week.

Thanks for the prompt response. I should have looked at the workflows more carefully, I missed that there was a pull_request: branches: trunk -- I'm used to CI that either doesn't exist (which is what I assumed based on the lack of any feedback in my personal PR) or that doesn't care about the target branch, in which case my personal PR would have triggered it and I would have worked w/ it until it was green before making this PR.

jsoref avatar Jun 24 '23 00:06 jsoref

I've currently dropped spelling: secret, but I'm testing a fixed version of it in https://github.com/check-spelling/poi/pull/2

jsoref avatar Jun 24 '23 00:06 jsoref

I can't figure out where the setCurrentUserPasswort comes from...

      Test #309 document/PasswordProtected.doc HWPF FAILED (1.2s)

      org.opentest4j.AssertionFailedError: document/PasswordProtected.doc - failed. Message: document is encrypted, password is invalid - use Biff8EncryptionKey.setCurrentUserPassword() to set password before opening - didn't contain: document is encrypted, password is invalid - use Biff8EncryptionKey.setCurrentUserPasswort() to set password before opening ==> expected: <true> but was: <false>
          at app/org.apache.poi.stress/org.apache.poi.stress.TestAllFiles.verify(TestAllFiles.java:259)

jsoref avatar Jun 25 '23 05:06 jsoref

Thanks, I'm happy to split out other pieces, e.g. perhaps things that don't rename files / apis / test data...

jsoref avatar Jun 27 '23 12:06 jsoref

Thanks @jsoref - I'm not 100% sure this is worth the effort. This is not even a live repo - the real code is in a subversion repo. So applying PRs to our code is very manual and time consuming.

Over time, I can come back to this PR and grab a couple more changes and apply them myself.

pjfanning avatar Jun 27 '23 12:06 pjfanning

Yeah, I noticed the svn bits.

Anyway, thanks for working on this and the project in general. My employer uses this library :)

jsoref avatar Jun 27 '23 12:06 jsoref