Wrong controller zookeeper config in "conf/pinot-controller.conf"

[thangnd197]

The zookeeper string key in "conf/pinot-controller.conf" must be "controller.zk.str" Please take a look in docs https://docs.pinot.apache.org/configuration-reference/controller

When start controller node with

bin/pinot-admin.sh StartController -configFileName conf/pinot-controller.conf

I have below error

Caught exception while starting controller, exiting.
java.lang.NullPointerException: null
	at org.apache.pinot.tools.admin.command.StartControllerCommand.getControllerConf(StartControllerCommand.java:207) ~[pinot-all-0.11.0-jar-with-dependencies.jar:0.11.0-1b4d6b6b0a27422c1552ea1a936ad145056f7033]
	at org.apache.pinot.tools.admin.command.StartControllerCommand.execute(StartControllerCommand.java:183) [pinot-all-0.11.0-jar-with-dependencies.jar:0.11.0-1b4d6b6b0a27422c1552ea1a936ad145056f7033]
	at org.apache.pinot.tools.Command.call(Command.java:33) [pinot-all-0.11.0-jar-with-dependencies.jar:0.11.0-1b4d6b6b0a27422c1552ea1a936ad145056f7033]
	at org.apache.pinot.tools.Command.call(Command.java:29) [pinot-all-0.11.0-jar-with-dependencies.jar:0.11.0-1b4d6b6b0a27422c1552ea1a936ad145056f7033]
	at picocli.CommandLine.executeUserObject(CommandLine.java:1953) [pinot-all-0.11.0-jar-with-dependencies.jar:0.11.0-1b4d6b6b0a27422c1552ea1a936ad145056f7033]
	at picocli.CommandLine.access$1300(CommandLine.java:145) [pinot-all-0.11.0-jar-with-dependencies.jar:0.11.0-1b4d6b6b0a27422c1552ea1a936ad145056f7033]
	at picocli.CommandLine$RunLast.executeUserObjectOfLastSubcommandWithSameParent(CommandLine.java:2352) [pinot-all-0.11.0-jar-with-dependencies.jar:0.11.0-1b4d6b6b0a27422c1552ea1a936ad145056f7033]
	at picocli.CommandLine$RunLast.handle(CommandLine.java:2346) [pinot-all-0.11.0-jar-with-dependencies.jar:0.11.0-1b4d6b6b0a27422c1552ea1a936ad145056f7033]
	at picocli.CommandLine$RunLast.handle(CommandLine.java:2311) [pinot-all-0.11.0-jar-with-dependencies.jar:0.11.0-1b4d6b6b0a27422c1552ea1a936ad145056f7033]
	at picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.java:2179) [pinot-all-0.11.0-jar-with-dependencies.jar:0.11.0-1b4d6b6b0a27422c1552ea1a936ad145056f7033]
	at picocli.CommandLine.execute(CommandLine.java:2078) [pinot-all-0.11.0-jar-with-dependencies.jar:0.11.0-1b4d6b6b0a27422c1552ea1a936ad145056f7033]
	at org.apache.pinot.tools.admin.PinotAdministrator.execute(PinotAdministrator.java:165) [pinot-all-0.11.0-jar-with-dependencies.jar:0.11.0-1b4d6b6b0a27422c1552ea1a936ad145056f7033]
	at org.apache.pinot.tools.admin.PinotAdministrator.main(PinotAdministrator.java:196) [pinot-all-0.11.0-jar-with-dependencies.jar:0.11.0-1b4d6b6b0a27422c1552ea1a936ad145056f7033]

[xiangfu0]

Thanks for reporting this!

I think we need to align the code: https://github.com/apache/pinot/blob/master/pinot-controller/src/main/java/org/apache/pinot/controller/ControllerConf.java#L429 and https://github.com/apache/pinot/blob/master/pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/StartControllerCommand.java#L207

Do you want to submit a PR to let StartControllerCommand also handle CONFIG_OF_ZOOKEEPR_SERVER = "pinot.zk.server"; from the class org.apache.pinot.spi.utils.CommonConstants

[ji10-hada]

I am also, facing the same issue kindly help me. Thankyou for support.

[xiangfu0]

I am also, facing the same issue kindly help me. Thankyou for support.

Use controller.zk.str for controller conf

[rohit-mobstac]

@xiangfu0 I have tried controller.zk.str and passed the zookeeper ensemble IPs. That doesn’t seem to work either. Does StartController support something like we pass zookeeper addresses as - zkAddress parameter from CLI and remove controller.zk.str from the config?

[rohit-mobstac]

@xiangfu0 I have tried controller.zk.str and passed the zookeeper ensemble IPs. That doesn’t seem to work either. Does StartController support something like we pass zookeeper addresses as - zkAddress parameter from CLI and remove controller.zk.str from the config?

Seems like it doesnt. Getting same error after removing zk conf from config and passing it as -zkAddress. Overriding through CLI parameters isnt supported, maybe?